Skip to content

Fix: #56 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix: #56 #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83c7adb
Fix: #56
note11g Jan 4, 2024
59a5d2d
Remove: Unnecessary Example App code (because #56 issue resolved)
note11g Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...d/src/main/kotlin/dev/note11/flutter_naver_map/flutter_naver_map/FlutterNaverMapPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package dev.note11.flutter_naver_map.flutter_naver_map

import android.app.Activity
import android.content.Context
import dev.note11.flutter_naver_map.flutter_naver_map.sdk.SdkInitializer
import dev.note11.flutter_naver_map.flutter_naver_map.view.NaverMapViewFactory
Expand Down Expand Up @@ -28,14 +29,19 @@ internal class FlutterNaverMapPlugin : FlutterPlugin, ActivityAware {
override fun onDetachedFromEngine(binding: FlutterPlugin.FlutterPluginBinding) = Unit

override fun onAttachedToActivity(binding: ActivityPluginBinding) {
val activity = binding.activity
val naverMapViewFactory =
NaverMapViewFactory(binding.activity, pluginBinding.binaryMessenger)
NaverMapViewFactory(activity, pluginBinding.binaryMessenger)
correctDisplayOnFlutterNavigatorStackWithActivityBackgroundMode(activity)
pluginBinding.platformViewRegistry.registerViewFactory(
MAP_VIEW_TYPE_ID,
naverMapViewFactory
MAP_VIEW_TYPE_ID, naverMapViewFactory
)
}

private fun correctDisplayOnFlutterNavigatorStackWithActivityBackgroundMode(activity: Activity) {
activity.intent.putExtra("background_mode", "transparent")
}

override fun onDetachedFromActivityForConfigChanges() = Unit

override fun onReattachedToActivityForConfigChanges(binding: ActivityPluginBinding) = Unit
Expand Down
7 changes: 1 addition & 6 deletions ...pp/src/main/kotlin/dev/note11/flutter_naver_map/flutter_naver_map_example/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,4 @@ package dev.note11.flutter_naver_map.flutter_naver_map_example
import android.os.Bundle
import io.flutter.embedding.android.FlutterActivity

class MainActivity : FlutterActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
intent.putExtra("background_mode", "transparent")
super.onCreate(savedInstanceState)
}
}
class MainActivity : FlutterActivity() {}