1.2.0 release #183
Merged
1.2.0 release #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-nullable (with defaultInitialCameraPosition), Fix #117
…ters with default values
…tude from Future<double> to double (non-async function)
leehack
approved these changes
Feb 16, 2024
Comment on lines
+22
to
+26
| Text(title, | ||
| style: getTextTheme(context).titleMedium, | ||
| maxLines: 1, | ||
| softWrap: false, | ||
| overflow: TextOverflow.fade), |
There was a problem hiding this comment.
nit:
Suggested change
| Text(title, | |
| style: getTextTheme(context).titleMedium, | |
| maxLines: 1, | |
| softWrap: false, | |
| overflow: TextOverflow.fade), | |
| Text( | |
| title, | |
| style: getTextTheme(context).titleMedium, | |
| maxLines: 1, | |
| softWrap: false, | |
| overflow: TextOverflow.fade, | |
| ), |
Comment on lines
+17
to
+21
| Color get buttonColor => nightMode ? Colors.grey.shade900 : Colors.white; | ||
| Color get iconColor => | ||
| nightMode ? Colors.grey.shade200 : Colors.grey.shade800; | ||
| Color get dividerColor => | ||
| nightMode ? Colors.grey.shade700 : Colors.grey.shade200; |
There was a problem hiding this comment.
nit: Maybe it would be more flexible if the dark and light colors were defined in the constructor with default values.
There was a problem hiding this comment.
맞습니다. 다만, 이게 API 형태로 어떻게 노출될 지를 결정해야할 수도 있어서 일단은 기존 SDK의 줌 컨트롤 위젯을 모방했습니다.
#173 이 아직 작업중이므로, 작업에 참고하도록 하겠습니다. 감사합니다!
|
리뷰해주신 리핵님께(@leehack ) 감사드립니다!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업중이었던 #173 은 다음버전에서 제공될 예정입니다.
1.2.0
Improve
NaverMapController.nowCameraPositionas a experimental api which type isNCameraPosition(non-async)NCameraUpdate.setReasonNaverMapController.getMeterPerDp&
NaverMapController.getMeterPerDpAtLatitudeto non-async (Future -> double)NCameraUpdate.setAnimationto have non-null parameters with default valuesNaverMapViewOptions.initialCameraPositionto non-nullable typeBreaking Change
Fix