deps: float 856a47b on node-gyp #1976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change to "correctly rename object files for absolute paths" caused a bug in windows. A fix has already landed upstream in gyp-next and been release as 0.6.2, but has not yet made it's way to a release of node-gyp. This float the upgrade to 0.6.2 in node-gyp Closes: npm#1974 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.2 Refs: nodejs/node-gyp#2241 Signed-off-by: Myles Borins <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to "correctly rename object files for absolute paths"
caused a bug in windows. A fix has already landed upstream in
gyp-next and been release as 0.6.2, but has not yet made it's
way to a release of node-gyp.
This float the upgrade to 0.6.2 in node-gyp
Closes: #1974
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.2
Refs: nodejs/node-gyp#2241
Signed-off-by: Myles Borins [email protected]