Configuration Definition Refactor, Phase 1 #2878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in refactoring our configuration definition, flattening, and documentation.
Still TODO:
npm.flatOptions
in lib/cli, other than passing to dependencies. (@wraithgar is working on this in another PR)saveType
)Furthermore, explore whether the flatOptions dirty flag should be "you need to regenerate all of these", or a dirty flag for the individual fields that might have changed, or just an object full of getters for each one. The current approach (generate flat options if missing, throw away when
config.set()
changes anything) is naive, but simple and probably performant enough.