Skip to content

Conversation

gijun19
Copy link

@gijun19 gijun19 commented May 20, 2021

Details

Release v7.14.0 gave us an error with docs related to npm-pack. This PR includes a patch where we ran make docs and the changes.

Adds "PR Validation Checks" workflow for pull requests on branches release-next and latest.

  1. pr-title-format will check if the PR title follows conventional commits formatting
  2. clean-working-dir will check if we have a clean working directory after forcing a regeneration of docs and running make prune

References

Closes #3275

@gijun19 gijun19 requested a review from darcyclarke May 20, 2021 23:17
@gijun19 gijun19 requested a review from a team as a code owner May 20, 2021 23:17
@gijun19
Copy link
Author

gijun19 commented May 20, 2021

gijun19#2

As per documentation, for this to work across forks the workflow needs to exist on the main branch. So this needs to get merged into npm/cli before workflows work properly. The docs for the action can be found here

I posted a link to the PR from my pr branch into my fork. you can see the checks passed successfully there. we're just changing the event trigger to be pull_request_target from pull_request for this to work for PRs coming from forks.

@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes labels May 21, 2021
@gijun19 gijun19 merged commit 671fa42 into npm:release-next May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants