fix(arborist): shrinkwrap throws when trying to read a folder without permissions #4258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issions Fix an issue where shrinkwrap throws an error when trying to read a folder that it doesn't have permissions to, instead of returning a correct object with an error
This comment has been minimized.
This comment has been minimized.
Linkgoron
force-pushed
the
arborist-eaccess-error
branch
2 times, most recently
from
0282ef0 to
1910c8f
Compare
Linkgoron
force-pushed
the
arborist-eaccess-error
branch
from
1910c8f to
bfbd139
Compare
ruyadorno
suggested changes
Jan 20, 2022
There was a problem hiding this comment.
thanks @Linkgoron 😄 I believe it's going to be a simpler and easier to maintain in the long term test if we just skip windows for now
ruyadorno
added
semver:patch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor regression introduced here where
Shrinkwrap.loadthrows an error instead of returning correctly when arborist doesn't have access to the folder it's trying to read.The issue is caused by trying to log
const rel = relpath(this.path, this.filename)whenthis.filenameis null.this.filenameis set afterthis[_maybeRead]()executes, but when there are permission issuesthis[_maybeRead]()throws, andthis.filenamestaysnull, andrelpath(and consequentially,load) throwsThe "to" argument must be of type stringerror.I've changed the code to only execute
relpathifthis.filenameis set correctly.