Skip to content

npm doctor improvements #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2022
Merged

npm doctor improvements #4495

merged 4 commits into from
Mar 10, 2022

Conversation

wraithgar
Copy link
Member

  • chore: mocknpm improvements
  • chore: rewrite doctor tests
  • fix(doctor): don't retry ping
  • fix(doctor): allow for missing local bin and node_modules

@wraithgar wraithgar requested a review from a team as a code owner March 3, 2022 18:08
@wraithgar wraithgar changed the title gar/doctor tests npm doctor improvements Mar 3, 2022
@wraithgar wraithgar force-pushed the gar/doctor-tests branch 3 times, most recently from da39e80 to 113c824 Compare March 3, 2022 18:36
@wraithgar wraithgar marked this pull request as draft March 3, 2022 18:49
@wraithgar
Copy link
Member Author

Converting to draft till the windows tests are fixed, and the mock globals stuff is implemented

@npm-robot
Copy link
Contributor

npm-robot commented Mar 3, 2022 •
edited
Loading

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 65.484 ±0.78 36.298 ±0.04 22.659 ±0.09 25.136 ±0.97 3.656 ±0.01 3.744 ±0.12 2.910 ±0.05 14.985 ±0.27 2.912 ±0.02 4.113 ±0.04
#4495 66.173 ±2.00 35.773 ±0.22 22.430 ±0.01 25.613 ±0.88 3.716 ±0.13 3.812 ±0.05 2.859 ±0.02 15.222 ±0.19 2.978 ±0.03 4.268 ±0.19
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 41.948 ±0.27 27.705 ±0.01 15.973 ±0.08 17.470 ±0.10 3.332 ±0.03 3.300 ±0.11 3.009 ±0.03 11.074 ±0.05 2.762 ±0.02 3.713 ±0.03
#4495 42.278 ±2.04 28.078 ±0.08 16.320 ±0.19 17.820 ±0.32 3.284 ±0.03 3.341 ±0.03 2.882 ±0.08 11.106 ±0.06 2.798 ±0.06 3.812 ±0.14

@wraithgar wraithgar mentioned this pull request Mar 3, 2022
Closed
wraithgar added 3 commits March 7, 2022 07:16
@wraithgar
chore: mocknpm improvements
dc10418 
make tests pass in prefixDir instead of testdir
allow for cache and globalPrefix dirs
@wraithgar
chore: rewrite doctor tests
5f90d92
@wraithgar
fix(doctor): don't retry ping
d4ff4fb
@wraithgar wraithgar force-pushed the gar/doctor-tests branch 4 times, most recently from a515da3 to b17e900 Compare March 7, 2022 15:55
@wraithgar wraithgar marked this pull request as ready for review March 7, 2022 16:37
@wraithgar wraithgar changed the base branch from release-next to latest March 9, 2022 18:23
@ruyadorno ruyadorno added Release 8.x work is associated with a specific npm 8 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Mar 9, 2022
@ruyadorno ruyadorno merged commit 55ab38c into latest Mar 10, 2022
@ruyadorno ruyadorno deleted the gar/doctor-tests branch March 10, 2022 15:40
@ruyadorno ruyadorno mentioned this pull request Mar 10, 2022
Merged
@npm-robot npm-robot mentioned this pull request Mar 10, 2022
Closed
@nlf nlf mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lukekarrys lukekarrys lukekarrys approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wraithgar @npm-robot @lukekarrys @ruyadorno