Skip to content

fix(run-script): don't cascade if-present config #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2022
Merged

fix(run-script): don't cascade if-present config #4678

merged 1 commit into from
Apr 5, 2022

Conversation

ruyadorno
Copy link
Contributor

Do not pass the if-present env config value to spawned processes.

References

Fixes: #3352
Close: #3589

cc @wraithgar

@ruyadorno
fix(run-script): don't cascade if-present config
db8ecab 
Do not pass the `if-present` env config value to spawned processes.

Fixes: npm#3352
Close: npm#3589
@ruyadorno ruyadorno requested a review from a team as a code owner April 4, 2022 21:58
@ruyadorno ruyadorno added semver:patch semver patch level for changes Release 8.x work is associated with a specific npm 8 release labels Apr 4, 2022
@wraithgar wraithgar merged commit 840c338 into npm:latest Apr 5, 2022
@lukekarrys lukekarrys mentioned this pull request Apr 14, 2022
Merged
@npm-robot npm-robot mentioned this pull request Apr 14, 2022
Closed
@Omrisnyk Omrisnyk mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm run <script name> --if-present silently ignores missing scripts in subcommands
2 participants
@ruyadorno @wraithgar