fix: don't fail immediately if cache dir is not accessible #5197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add a test for this, obviously. 😶🌫️ |
|
no statistically significant performance changes detected timing results
|
lukekarrys
force-pushed
the
lk/readonly
branch
2 times, most recently
from
a3733a9 to
44c060c
Compare
lukekarrys
force-pushed
the
lk/readonly
branch
2 times, most recently
from
1cac26a to
be3afd1
Compare
This also changes all the log messages about not being able to create initial directories and files to `log.verbose` since we know run those commands on init. There are a lot of valid reasons why those might fail, and we don't want to show a warning for them every time. Fixes: #4769 Fixes: #4838 Fixes: #4996
wraithgar
approved these changes
Jul 20, 2022
|
Could you please release a new version with this? |
|
@vojty releases happen weekly on Wednesday. https://github.com/npm/cli/wiki/Release-Process-(v8) |
Merged
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes all the log messages about not being able to create
initial directories and files to
log.verbosesince we know run thosecommands on init. There are a lot of valid reasons why those might fail,
and we don't want to show a warning for them every time.
Fixes: #4769
Fixes: #4838
Fixes: #4996