fix(config): remove node-version and npm-version
#5691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes npm/statusboard#575 |
|
Didn't see the snapshot. Gotta fix that. |
wraithgar
force-pushed
the
gar/rm-node-npm-version
branch
3 times, most recently
from
5dd596e to
55748be
Compare
BREAKING CHANGE: the `node-version` and `npm-version` configs have been removed. These are only used sparingly by arborist to determine if optional dependencies should be installed, and during engines checks (which are only warnings unless `engine-strict` is true.
wraithgar
force-pushed
the
gar/rm-node-npm-version
branch
from
55748be to
f697c50
Compare
fritzy
approved these changes
Oct 13, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the
node-versionandnpm-versionconfigs have beenremoved.
These are only used sparingly by arborist to determine if optional
dependencies should be installed, and during engines checks (which
are only warnings unless
engine-strictis true.