-
Notifications
You must be signed in to change notification settings - Fork 3.7k
docs: fix workspaces example #6714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ref: | ||
required: true | ||
type: string | ||
default: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a commit from another branch snuck in here. You'll probably want to start w/ a fresh branch off of latest
, or rebase this, or drop this commit from your branch.
Specify the right path for workspace "a"
affd680
to
8c50d12
Compare
Hello, I dropped the commit we didn't want. Hope this helps. |
|
||
``` | ||
npm install abbrev -w a | ||
npm install abbrev -w packages/a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was actually correct, and included to show that the -w
flag accepts the name of the workspace, not just the path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the name
attribute of the package.json
in packages/app
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I get it. The argument to -w
is not the directory name but the package name defined in package.json
. Sorry for the misunderstanding, but it's not precisely stated in the documentation. The example used in documentation is directory structure oriented, hence my confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Perhaps the examples could be updated so the directory and package names differ, to make this more clear?
Specify the right path for workspace "a"