Skip to content

Conversation

fvilers
Copy link

@fvilers fvilers commented Aug 17, 2023

Specify the right path for workspace "a"

@fvilers fvilers requested a review from a team as a code owner August 17, 2023 10:10
@fvilers fvilers mentioned this pull request Aug 17, 2023
ref:
required: true
type: string
default: latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a commit from another branch snuck in here. You'll probably want to start w/ a fresh branch off of latest, or rebase this, or drop this commit from your branch.

@npm npm deleted a comment from infamous100 Aug 18, 2023
Specify the right path for workspace "a"
@fvilers
Copy link
Author

fvilers commented Aug 29, 2023

Hello, I dropped the commit we didn't want. Hope this helps.

@wraithgar wraithgar changed the title Update workspaces.md (v10) docs: fix workspaces example Aug 29, 2023
wraithgar
wraithgar previously approved these changes Aug 29, 2023
@wraithgar wraithgar self-requested a review August 29, 2023 13:53

```
npm install abbrev -w a
npm install abbrev -w packages/a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually correct, and included to show that the -w flag accepts the name of the workspace, not just the path.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not working here (Windows 10, Node 18.15.0)

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the name attribute of the package.json in packages/app?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I get it. The argument to -w is not the directory name but the package name defined in package.json. Sorry for the misunderstanding, but it's not precisely stated in the documentation. The example used in documentation is directory structure oriented, hence my confusion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Perhaps the examples could be updated so the directory and package names differ, to make this more clear?

@wraithgar wraithgar dismissed their stale review August 29, 2023 13:55

This PR isn't actually needed

@wraithgar wraithgar closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants