fix(npx): always save true when installing to npx cache #8154
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milaninfy
force-pushed
the
mm/fix-npx-invalid-cache
branch
from
1549b64 to
7350e96
Compare
wraithgar
reviewed
Mar 10, 2025
| save: false, | ||
| }) | ||
|
|
||
| t.match(await readOutput('@npmcli-create-index'), { |
There was a problem hiding this comment.
the test should be the existence of the package.json file. I believe thanks to @owlstronaut there is code in the libnpmexec tests that let you calculate the cache directory.
There was a problem hiding this comment.
Added assertion to test existence of package.json file. 👍
milaninfy
force-pushed
the
mm/fix-npx-invalid-cache
branch
from
875c165 to
02988df
Compare
owlstronaut
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override config
saveto always betruewhen installing to the npx cache.fixes: #8151