Skip to content
This repository was archived by the owner on Feb 7, 2023. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ jobs:
- name: Install dependencies
run: npm ci

- name: Test Puka
if: ${{ !endsWith(matrix.node-version, '.0.x') }}
shell: bash
run: cd puka-dev && yarn && npm test

- name: Run Tap Tests
run: npm test

Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@
!/test
!/README*
!/LICENSE*

!/puka-dev
!/.taprc
2 changes: 2 additions & 0 deletions .taprc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
nyc-arg: [-x, puka-dev]
test-ignore: puka-dev
6 changes: 4 additions & 2 deletions lib/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { ShellString, unquoted } = require('puka')
const { ShellString, immediateExecOptions, unquoted } = require('../puka-dev')
const inferOwner = require('infer-owner')
const spawn = require('@npmcli/promise-spawn')

Expand Down Expand Up @@ -38,7 +38,9 @@ const exec = async (command, args, options, extra) => {
const finalArgs = [
...shell.args,
// allow puka to escape the args, but not the provided command
ShellString.sh`${unquoted(command)} ${args}`.toString(shell.escapeStyle),
// immediateExecOptions makes it okay to use the filesystem, environment,
// current working directory, etc. for the most accurate possible escaping
ShellString.sh`${unquoted(command)} ${args}`.toString(shell.escapeStyle, immediateExecOptions),
]
const child = spawn(finalCommand, finalArgs, finalOptions, extra)

Expand Down
16 changes: 1 addition & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
},
"dependencies": {
"@npmcli/promise-spawn": "^2.0.0",
"infer-owner": "^1.0.4",
"puka": "^1.0.1"
"infer-owner": "^1.0.4"
}
}
9 changes: 9 additions & 0 deletions puka-dev/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
insert_final_newline = true
charset = utf-8
trim_trailing_whitespace = true
end_of_line = lf
indent_style = space
indent_size = 2
168 changes: 168 additions & 0 deletions puka-dev/.eslintrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,168 @@
env:
es6: true
node: true
plugins:
- import
extends:
- eslint:recommended
- plugin:import/recommended
parser: babel-eslint
parserOptions:
sourceType: module
rules:
arrow-parens:
- error
- as-needed
capitalized-comments:
- error
- always
- {ignoreConsecutiveComments: true}
curly:
- error
- multi-line
- consistent
dot-location:
- error
- property
eqeqeq:
- error
- always
- {null: ignore}
generator-star-spacing:
- error
- {before: false, after: true}
indent:
- error
- 2
- {flatTernaryExpressions: true}
object-curly-spacing:
- error
- always
operator-linebreak:
- error
- before
- overrides:
'=': after
'+=': after
'-=': after
'*=': after
'/=': after
'%=': after
'**=': after
'<<=': after
'>>=': after
'>>>=': after
'&=': after
'^=': after
'|=': after
padded-blocks:
- error
- {blocks: never, classes: never, switches: never}
prefer-destructuring:
- error
- {VariableDeclarator: {array: false, object: true}}
quote-props:
- error
- as-needed
semi:
- error
- always
space-before-function-paren:
- error
- {anonymous: always, named: never, asyncArrow: always}
import/order:
- error
- {newlines-between: never}
array-bracket-spacing: error
array-callback-return: error
arrow-body-style: error
arrow-spacing: error
block-spacing: error
brace-style: error
camelcase: error
comma-spacing: error
computed-property-spacing: error
dot-notation: error
func-call-spacing: error
key-spacing: error
keyword-spacing: error
max-len: error
no-array-constructor: error
no-caller: error
no-cond-assign: off
no-control-regex: off
no-eval: error
no-extra-bind: error
no-extra-label: error
no-extra-parens: error
no-implied-eval: error
no-multi-spaces: error
no-multiple-empty-lines: error
no-new-func: error
no-new-object: error
no-new-require: error
no-new-wrappers: error
no-proto: error
no-return-await: error
no-throw-literal: error
no-undefined: error
no-unneeded-ternary: error
no-useless-call: error
no-useless-computed-key: error
no-useless-concat: error
no-useless-constructor: error
no-useless-rename: error
no-useless-return: error
no-whitespace-before-property: error
no-with: error
no-var: error
object-shorthand: error
operator-assignment: error
prefer-arrow-callback: error
prefer-const: error
prefer-numeric-literals: error
prefer-promise-reject-errors: error
prefer-rest-params: error
rest-spread-spacing: error
semi-spacing: error
semi-style: error
space-in-parens: error
space-infix-ops: error
space-unary-ops: error
spaced-comment: error
switch-colon-spacing: error
strict: error
template-curly-spacing: error
template-tag-spacing: error
yield-star-spacing: error
import/extensions: error
import/first: error
import/newline-after-import: error
import/no-extraneous-dependencies: error
import/unambiguous: off
# The below rules currently have no effect; they're left over from when I
# played with extending other configs.
consistent-return: off
default-case: off
function-paren-newline: off
no-confusing-arrow: off
no-lonely-if: off
no-mixed-operators: off
no-multi-assign: off
no-nested-ternary: off
no-param-reassign: off
no-plusplus: off
no-restricted-syntax: off
no-return-assign: off
no-sequences: off
no-shadow: off
no-underscore-dangle: off
no-unused-expressions: off
no-use-before-define: off
no-void: off
one-var: off
one-var-declaration-per-line: off
prefer-spread: off
prefer-template: off
quotes: off
import/prefer-default-export: off
7 changes: 7 additions & 0 deletions puka-dev/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/.nyc_output
/coverage
/coverage.lcov
/dist/*
!/dist/CHANGELOG.md
!/dist/index.js
node_modules
18 changes: 18 additions & 0 deletions puka-dev/LICENSE.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
Copyright 2017 Ryan Hendrickson <[email protected]>

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Loading