Skip to content
This repository was archived by the owner on Nov 16, 2019. It is now read-only.

Never ignore 'browser' file #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Never ignore 'browser' file #26

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Feb 14, 2017

This will prevent issues like
browserify/browserify#1687, where a user
has a 'files' list, or .npmignore file, and inadvertently tries to
exclude their browserify/webpack entry point.

This will prevent issues like
browserify/browserify#1687, where a user
has a 'files' list, or .npmignore file, and inadvertently tries to
exclude their browserify/webpack entry point.
@coveralls
Copy link

coveralls commented Feb 14, 2017

Coverage Status

Coverage increased (+0.2%) to 86.905% when pulling 7fbbd92 on browser-ignored into b839e06 on master.

@ghost
Copy link

ghost commented Feb 14, 2017

The browser field can also be an object that maps local aliases to file paths: https://github.com/defunctzombie/package-browser-field-spec#replace-specific-files---advanced

Also keep in mind the false case.

zkat
zkat previously approved these changes Mar 7, 2017
@zkat zkat dismissed their stale review March 7, 2017 21:53

oops, misread

@zkat zkat self-requested a review March 7, 2017 21:53
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @substack says, this field can be an object, so we should take care of that case too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants