This repository was archived by the owner on Nov 16, 2019. It is now read-only.
Always include npm shrinkwrap data in pack #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,7 +204,7 @@ Packer.prototype.readRules = function (buf, e) { | |||
| if (this === this.root) { | |||
| this.bundleLinks = this.bundleLinks || {} | |||
| this.bundleLinks[p.name] = this._path | |||
| } | |||
| }pa | |||
There was a problem hiding this comment.
Pretty sure the pa was included by mistake and will cause Bad Things to happen. Remove that?
There was a problem hiding this comment.
Indeed, fixed the typo, thanks.
Packages which have a 'files' property in their 'package.json' file and want to publish a dependency-frozen package with npm-shrinkwrap need to explicitly state that npm-shrinkwrap.json file is to be included in the tarball. NPM metadata is to be automatically 'included' in the tarball, like 'package.json' is.
|
This will need a test before we land it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages which have a
filesproperty in theirpackage.jsonfile and want to publish a dependency-frozen package with npm-shrinkwrap need to explicitly state thatnpm-shrinkwrap.jsonfile is to be included in the tarball.NPM metadata is to be automatically included in the tarball, like
package.jsonis.Packages used to require an npm-specific file in their declaration:
Now just need to specify their own file: