Skip to content

maxBytesPerFile acts like minBytesPerFile #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kev1n80 opened this issue Jun 11, 2021 · 1 comment · Fixed by #34
Closed

maxBytesPerFile acts like minBytesPerFile #30

kev1n80 opened this issue Jun 11, 2021 · 1 comment · Fixed by #34
Labels

Comments

@kev1n80
Copy link
Contributor

kev1n80 commented Jun 11, 2021

Since writeOne() checks if the file size exceeds the limit after writing the data instead of checking if writing the data will cause the file size to exceed the limit before writing, this causes the maximum file size to be maxBytesPerFile + maxMsgSize + 3.

@mreiferson mreiferson added the bug label Jun 12, 2021
@mreiferson
Copy link
Member

Good catch, I suppose we should do this check the other way around and from a quick scan of the code I think everything else should work (particularly after #23)

ploxiln added a commit to ploxiln/go-diskqueue that referenced this issue Sep 12, 2021
rather than switching *after* maxBytesPerFile is reached

fixes nsqio#30
ploxiln added a commit to ploxiln/go-diskqueue that referenced this issue Sep 12, 2021
rather than switching *after* maxBytesPerFile is reached

fixes nsqio#30
ploxiln added a commit to ploxiln/go-diskqueue that referenced this issue Sep 12, 2021
rather than switching *after* maxBytesPerFile is reached

fixes nsqio#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants