Skip to content

Conversation

Romfos
Copy link
Contributor

@Romfos Romfos commented Oct 8, 2025

Changed:

  • Move target tfms from matrix to steps

Motivation:
Each new test TFM will add +3 new jobs to test matrix (for each OS).
Make sense to run all test for OS in one job

this is part of preparation for adding .NET 10 to test matrix

@Romfos Romfos mentioned this pull request Oct 8, 2025
23 tasks
@Romfos Romfos changed the title Simplify github actions to use less runners Simplify github actions to use less jobs Oct 8, 2025
@Romfos Romfos requested a review from Copilot October 8, 2025 17:35
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the GitHub Actions test workflow by consolidating multiple jobs into fewer jobs. Instead of using a matrix strategy that creates separate jobs for each OS-framework combination, the workflow now runs all target framework tests as separate steps within each OS job.

  • Removed the framework matrix dimension and Windows-specific include configuration
  • Added individual test steps for each target framework (.NET Framework 4.6.2, .NET 8, .NET 9)
  • Conditional execution for .NET Framework tests only on Windows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Romfos Romfos requested a review from dtchepak October 8, 2025 17:36
@dtchepak dtchepak merged commit 9567b02 into nsubstitute:main Oct 12, 2025
4 checks passed
@Romfos Romfos deleted the actions branch October 12, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants