Use base_prefix, not prefix for iOS framework linking. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rgommers do we want single backports or will there be a general meson update? Also relevant for numpy/numpy#29454 |
|
As commented in numpy/numpy#29454, I'm fine with small backports right now. Especially if they're this trivial and the PR is already opened:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of mesonbuild#14849.
Modifies iOS linking with the Python framework to use
sys.base_prefix, rather thansys.prefix.Outside of a venv,
sys.prefixandsys.base_prefixare the same. However, if you're using a virtual environment.sys.prefixpoints at the location of the virtual environment, not the location of the iOS binaries.sys.base_prefixshould be used to ensure that you're always referencing the underlying install location, not the venv location.