Skip to content

Add cpp-linter action #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Add cpp-linter action #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b0512f
Add cpp-linter action
Mousius Jun 9, 2025
b731161
Move to just Google style for C++
Mousius Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
BasedOnStyle: Google
25 changes: 25 additions & 0 deletions .github/workflows/cpp-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: cpp-linter

on:
pull_request:
branches:
- main
paths:
- "npsr/*"

jobs:
cpp-linter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- uses: cpp-linter/cpp-linter-action@f91c446a32ae3eb9f98fef8c9ed4c7cb613a4f8a
id: linter
continue-on-error: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
style: "file"

- name: Linter Outputs
if: steps.linter.outputs.checks-failed != 0
Copy link
Preview

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions outputs are treated as strings; comparing checks-failed to an unquoted number may always evaluate to true. Use != '0' or compare as a string to correctly detect failures.

Suggested change
if: steps.linter.outputs.checks-failed != 0
if: steps.linter.outputs.checks-failed != '0'

Copilot uses AI. Check for mistakes.

run: exit 1