Skip to content

🩹 fix numpy.inner overload #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

guan404ming
Copy link
Member

closes #117

@guan404ming guan404ming changed the title 🩹fix numpy.inner overload 🩹 fix numpy.inner overload Mar 7, 2025
@guan404ming
Copy link
Member Author

guan404ming commented Mar 7, 2025

Hi, @jorenham please help me review, thanks~ Also, I would like to ask is there any suitable issue for me (beginner of open source). I think static type issue is cool and I would like to help to build this project~ 🔥

@jorenham jorenham added this to the v2.2.x.0 milestone Mar 7, 2025
@jorenham
Copy link
Member

jorenham commented Mar 7, 2025

Thanks Guan!

Also, I would like to ask is there any suitable issue for me (beginner of open source). I think static type issue is cool and I would like to help to build this project~ 🔥

I guess that depends on what you like doing. There are a some untyped modules listed in #73 that might me fun to work on. A bit more challenging would be to try and annotate one or a couple of ufuncs from #230. And there are of course also a bunch of open issues on improving existing function signatures, by narrowing the return dtypes or improving shape-typing.

As you already noticed, there are also a bunch of opportunities for improving the test coverage, either by writing tests yourself, of through automatic test generation like in https://github.com/numpy/numtype/blob/main/test/generate_scalar_binops.py.

You could look through the # TODO's and open an issue or PR for them: https://github.com/search?q=repo%3Anumpy%2Fnumtype+%23+TODO+path%3A%2F%5Esrc%5C%2Fnumpy-stubs%5C%2F%2F&type=code

Documentation is also completely lacking at this point, so if you're feeling adventurous, writing some would also be of great help.

@jorenham jorenham merged commit 9bf3100 into numpy:main Mar 7, 2025
13 checks passed
@guan404ming guan404ming deleted the fix-inner branch March 24, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy.inner is incorrect
2 participants