Skip to content

🖌️ adopt dprint #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

🖌️ adopt dprint #471

wants to merge 2 commits into from

Conversation

KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented Apr 7, 2025

reviewers note: config/formatting are split across two commits

resolves #393

@guan404ming
Copy link
Member

Thanks @KotlinIsland, LGTM!

@jorenham
Copy link
Member

jorenham commented Apr 7, 2025

there's a merge conflict

Copy link
Member

@jorenham jorenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm not sure I like the lack of configurability for the toml style, but it's probably better to be more like "black" this way.

@jorenham

This comment was marked as resolved.

@jorenham jorenham mentioned this pull request Aug 6, 2025
@jorenham
Copy link
Member

jorenham commented Aug 6, 2025

needs a rebase

Since I can't force-push to your branch, I branched from your branch and continued your work in #471.
So I guess I'm closing this then.

@jorenham jorenham closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use dprint
3 participants