-
-
Notifications
You must be signed in to change notification settings - Fork 459
Feature: cache validation rules #2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @spawnia, do you have time to check this PR? |
spawnia
reviewed
Sep 19, 2024
Co-authored-by: Benedikt Franke <[email protected]>
# Conflicts: # CHANGELOG.md
spawnia
reviewed
Sep 19, 2024
Co-authored-by: Benedikt Franke <[email protected]>
spawnia
reviewed
Sep 20, 2024
spawnia
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @k0ka!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2018
Changes
Added possibility to cache query validation successful result. So the 2nd time the query would appear, most validator won't run against it.
Notes:
hash
to\Nuwave\Lighthouse\Schema\AST\DocumentAST
ProvidesCacheableValidationRules
which extendsProvidesValidationRules
for backward compatibility. In the next release we might removeProvidesValidationRules
.Defer::executeDeferred
SubscriptionBroadcaster::broadcast
AsyncMutation::handle
Errors
might fail to serialize.lighthouse/src/GraphQL.php
Lines 393 to 397 in 0d8ea16
webonyx/graphql-php
, so there is no easy way to extend them and store hashes inside objects.I also added different benchmarks.
HugeRequestBench
creates requests with a lot of simple fragments: 1, 10 and 100 forbenchmark1
,benchmark10
andbenchmark100
respectively. Enabling validation cache improves execution time:benchmark1
from 4.222ms to 2.886msbenchmark10
from 14.984ms to 4.429msbenchmark100
from 189.641ms to 19.783ms