This repository was archived by the owner on Sep 3, 2024. It is now read-only.
Add/fix information on nuxtChildKey #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2019 17:19
Please refer to the following pull request in nuxt.js. nuxt/nuxt#5516
7 tasks
|
@atinux Base branch should be changed since the pr is a breaking change. |
|
Well actually the documentation was wrong and the default value was not |
|
@inouetakuya could you please resolve the conflicts for |
|
@atinux @inouetakuya |
|
Thanks @potato4d :) |
|
@inouetakuya |
clarkdo
reviewed
May 10, 2019
| @@ -10,7 +10,7 @@ description: 该组件用于在布局中显示页面组件（即非布局内容 | |||
| **Props**: | |||
| - nuxtChildKey: `string` | |||
| - 此prop将设置为`<router-view />`，可用于在动态页面和不同路径内进行转换。 | |||
| - 默认: `$route.fullPath` | |||
| - 默认: `$route.path` | |||
There was a problem hiding this comment.
@warriorBrian Could you please help to add Chinese translation when you have time ?
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the document-side pull request of nuxt/nuxt#5516.
I've updated documentation on
nuxtChildKeyprop.$route.fullPath.$route.pathis used by default.keyof<router-view/>is added.FYI, I did the task 1 and 2 for EN, DE, ES, JA and KO.
For the other languages, I did the task 1 because fullPath by default is wrong information and better be fixed soon.
cc: @potato4d and @DiyLecko