Skip to content

feat: add custom blue color for nuxt cli #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2019
Merged

feat: add custom blue color for nuxt cli #133

merged 4 commits into from
Sep 30, 2019

Conversation

danielroe
Copy link
Member

This PR changes the color of the Nuxt.js banner to blue for Typescript projects.

See nuxt/nuxt#6399 and nuxt/nuxt#6397

@kevinmarrec kevinmarrec added pending build The issue or pull request is related to `build` package feature Pull requests that implement a feature labels Sep 30, 2019
@kevinmarrec
Copy link
Contributor

kevinmarrec commented Sep 30, 2019 •
edited
Loading

Thanks @danielroe and great work around nuxt/nuxt#6399 💚

For now I've #97 && #122 that is waiting Nuxt 2.10 to be released.
This feature will be merged around these ones cause options.cli will only exist on Nuxt 2.10, as well as hooks.

People will be forced to upgrade Nuxt to use the next version of typescript support cause it fixes issues & overall provide better runtime support (nuxt-ts).

So for now i'm puting pending label :)

@kevinmarrec kevinmarrec merged commit 3534073 into nuxt:master Sep 30, 2019
kevinmarrec added a commit that referenced this pull request Sep 30, 2019
@kevinmarrec
fix(build): fix feature #133 after ts rewrite
1e453e6
NickBolles pushed a commit to NickBolles/typescript-1 that referenced this pull request Oct 25, 2019
@sibbng @atinux
Retrieve host and port values from nuxt instance (nuxt#133)
238e710 
* update express

* update koa

* update micro

* better implementation

* unnecessary micro.config.js removed
@danielroe danielroe deleted the add-custom-color-for-nuxt-cli branch November 30, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinmarrec kevinmarrec kevinmarrec approved these changes

Assignees

@danielroe danielroe

Labels
build The issue or pull request is related to `build` package feature Pull requests that implement a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @kevinmarrec