-
Notifications
You must be signed in to change notification settings - Fork 122
refactor: use hooks #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5fa6d2d
refactor: use hooks
kevinmarrec 4d91dfb
Merge branch 'master' into refactor/hooks
kevinmarrec 1eeaf5a
chore(deps): lock file maintenance
kevinmarrec cd6c08e
chore: finalize hooks
kevinmarrec cddf4de
fix: tests
kevinmarrec 250426a
Merge branch 'master' into refactor/hooks
kevinmarrec 75c3f99
Merge branch 'master' into refactor/hooks
kevinmarrec 1d8ef77
Merge branch 'master' into refactor/hooks
kevinmarrec b4be796
Merge branch 'master' into refactor/hooks
kevinmarrec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
export default { | ||
modules: [ | ||
'../../../packages/typescript-build' | ||
buildModules: [ | ||
'@nuxt/typescript-build' | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,11 @@ | ||
#!/usr/bin/env node | ||
|
||
const path = require('path') | ||
const { resolveNuxtBin, getRootdirFromArgv, registerTSNode } = require('..') | ||
const cli = (() => { try { return require('@nuxt/cli') } catch { return require('@nuxt/cli-edge') } })() | ||
|
||
function main () { | ||
const rootDir = getRootdirFromArgv() | ||
const tsConfigPath = path.resolve(rootDir, 'tsconfig.json') | ||
const { hooks } = require('..') | ||
|
||
registerTSNode(tsConfigPath) | ||
|
||
require(resolveNuxtBin()) | ||
} | ||
|
||
try { | ||
main() | ||
} catch (error) { | ||
require('consola').error(error) | ||
process.exit(1) | ||
} | ||
cli.run(null, hooks) | ||
.catch((error) => { | ||
require('consola').fatal(error) | ||
require('exit')(2) | ||
}) |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,24 @@ | ||
const path = require('path') | ||
const { register } = require('ts-node') | ||
|
||
const hooks = { | ||
'run:before' ({ argv, rootDir }) { | ||
const customPath = argv.find((_arg, index) => index > 0 && argv[index - 1] === '--tsconfig') | ||
const tsConfigPath = path.resolve(customPath || rootDir, customPath && customPath.endsWith('.json') ? '' : 'tsconfig.json') | ||
|
||
register({ | ||
project: tsConfigPath, | ||
compilerOptions: { | ||
module: 'commonjs' | ||
} | ||
}) | ||
}, | ||
|
||
config (config) { | ||
config.extensions = [...(config.extensions || []), 'ts'] | ||
} | ||
} | ||
|
||
module.exports = { | ||
...require('./resolve'), | ||
...require('./args'), | ||
registerTSNode: require('./register') | ||
hooks | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
import path from 'path' | ||
import { register } from 'ts-node' | ||
import { hooks } from '..' | ||
|
||
jest.mock('ts-node') | ||
|
||
describe('run:before hook', () => { | ||
beforeEach(() => { | ||
register.mockClear() | ||
}) | ||
|
||
test('registers ts-node', () => { | ||
hooks['run:before']({ argv: [], rootDir: 'path' }) | ||
|
||
expect(register).toHaveBeenCalledWith({ | ||
project: path.resolve('path', 'tsconfig.json'), | ||
compilerOptions: { | ||
module: 'commonjs' | ||
} | ||
}) | ||
}) | ||
|
||
test('registers ts-node (custom tsconfig.json path)', () => { | ||
hooks['run:before']({ argv: ['--tsconfig', 'custom/tsconfig.json'], rootDir: 'path' }) | ||
|
||
expect(register).toHaveBeenCalledWith({ | ||
project: path.resolve('custom/tsconfig.json'), | ||
compilerOptions: { | ||
module: 'commonjs' | ||
} | ||
}) | ||
}) | ||
|
||
test('registers ts-node (custom tsconfig.json dir path)', () => { | ||
hooks['run:before']({ argv: ['--tsconfig', 'custom'], rootDir: 'path' }) | ||
|
||
expect(register).toHaveBeenCalledWith({ | ||
project: path.resolve('custom/tsconfig.json'), | ||
compilerOptions: { | ||
module: 'commonjs' | ||
} | ||
}) | ||
}) | ||
}) | ||
|
||
describe('config hook', () => { | ||
test('adds ts extension (config.extensions is: defined)', () => { | ||
const config = { extensions: [] } | ||
|
||
hooks.config(config) | ||
|
||
expect(config.extensions).toContain('ts') | ||
}) | ||
|
||
test('adds ts extension (config.extensions is: undefined)', () => { | ||
const config = {} | ||
|
||
hooks.config(config) | ||
|
||
expect(config.extensions).toContain('ts') | ||
}) | ||
}) |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.