Skip to content

fix(components): refactor types after @nuxt/module-builder upgrade #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 12, 2025

Conversation

benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Apr 10, 2025

❓ Type of change

Resolves #2828, resolves #3290, resolves https://github.com/nuxt/ui-pro/issues/718

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR refactors how component types are handled following the @nuxt/module-builder upgrade to keep dynamic props autocomplete based on user's app.config.ts and generated theme (based on options https://ui.nuxt.com/getting-started/installation/pro/nuxt#themecolors).

Check this failed CI on nuxt.com after using @nuxt/ui after the upgrade: https://github.com/nuxt/nuxt.com/actions/runs/14356582555/job/40247328611?pr=1853

Also, the tailwind-variants computation based on #build/app.config that used to be done inside normal script has been moved to setup script which makes components dynamic when app.config.ts changes through HMR. I hope this will not degrade performances which was why this was done in normal script initially.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Apr 10, 2025

npm i https://pkg.pr.new/@nuxt/ui@3855

commit: 10e1467

Copy link
Contributor

nuxthub-admin bot commented Apr 10, 2025

βœ… Deployed ui3

Deployed ui3 10e1467 to preview

πŸ”— fix-types-module-builder.ui-6q2.pages.dev
πŸ“Œ acd99d33.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

@benjamincanac benjamincanac changed the title fix(components): refactor types after @nuxt/module-builder upgrade fix(components): refactor types after @nuxt/module-builder upgrade Apr 10, 2025
@benjamincanac benjamincanac marked this pull request as ready for review April 12, 2025 15:48
@benjamincanac benjamincanac merged commit 39c861a into v3 Apr 12, 2025
7 of 8 checks passed
@benjamincanac benjamincanac deleted the fix/types-module-builder branch April 12, 2025 15:53
benjamincanac added a commit to TribeWeb/ui that referenced this pull request Apr 13, 2025
@benjamincanac benjamincanac added the v3 #1289 label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime configuration change? Runtime component customization with updateAppConfig
1 participant