-
Notifications
You must be signed in to change notification settings - Fork 763
fix(components): refactor types after @nuxt/module-builder
upgrade
#3855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
β Deployed ui3
π View deployment logs |
@nuxt/module-builder
upgrade
benjamincanac
added a commit
to TribeWeb/ui
that referenced
this pull request
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Type of change
Resolves #2828, resolves #3290, resolves https://github.com/nuxt/ui-pro/issues/718
π Description
This PR refactors how component types are handled following the
@nuxt/module-builder
upgrade to keep dynamic props autocomplete based on user'sapp.config.ts
and generated theme (based on options https://ui.nuxt.com/getting-started/installation/pro/nuxt#themecolors).Also, the
tailwind-variants
computation based on#build/app.config
that used to be done inside normal script has been moved to setup script which makes components dynamic whenapp.config.ts
changes through HMR. I hope this will not degrade performances which was why this was done in normal script initially.π Checklist