Skip to content

fix(templates): put back args to watch in dev #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

sandros94
Copy link
Member

@sandros94 sandros94 commented Apr 30, 2025

πŸ”— Linked issue

Resolves #4016

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Reverts #3851

Ideally I would like to fully support HMR, but I'm not able to make it work.
For now reverting to a previous implementation is sufficient

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 added bug Something isn't working v3 #1289 vue labels Apr 30, 2025
@sandros94 sandros94 self-assigned this Apr 30, 2025
Copy link
Contributor

nuxthub-admin bot commented Apr 30, 2025

βœ… Deployed ui3

Deployed ui3 ff823e5 to preview

πŸ”— chore-revert-theme-build.ui-6q2.pages.dev
πŸ“Œ c9da9e71.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

Copy link

pkg-pr-new bot commented Apr 30, 2025

npm i https://pkg.pr.new/@nuxt/ui@4033

commit: ff823e5

@benjamincanac benjamincanac changed the title revert(theme): partially #3851 fix(templates): put back args to watch in dev mode Apr 30, 2025
@benjamincanac benjamincanac changed the title fix(templates): put back args to watch in dev mode fix(templates): put back args to watch in dev May 1, 2025
@benjamincanac benjamincanac merged commit c5bdec0 into v3 May 1, 2025
8 checks passed
@benjamincanac benjamincanac deleted the chore/revert-theme-build branch May 1, 2025 16:47
@benjamincanac
Copy link
Member

Thanks @sandros94! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v3 #1289 vue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong import in components: import template from "/home/runner/work/ui/ui/src/theme/table"
2 participants