fix: block content alignment #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a single line was correctly aligned with a block, but the others were overindented it was possible for the overindented lines to be unindented. This is not correct. The overindented lines shouldn't shift at all if at least one of the lines is correctly indented. This is to preserve manual formatting. This commit ensures the above functionality.
SlayerOfTheBad
pushed a commit
to SlayerOfTheBad/orgmode
that referenced
this pull request
Aug 16, 2024
* fix(indent): do not modify block indents if one line is correct Previously, if a single line was correctly aligned with a block, but the others were overindented it was possible for the overindented lines to be unindented. This is not correct. The overindented lines shouldn't shift at all if at least one of the lines is correctly indented. This is to preserve manual formatting. This commit ensures the above functionality. * fix(indent): ignore blank lines for block content indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits as part of it.
The first commit ensures when block contents have a single line at the correct indentation level and the rest of the contents are indented more than that line, the block contents won't have their indentation changed.
The second commit makes the block content indentation ignore blank lines. Meaning it won't modify indentation if a blank line is "underindented" relative to the header as it was previously.
I wrote tests as part of each commit to exercise each path. Please see them to see specific examples. Each commit has its own tests associated, so it may be easier to view them that way.
Let me know if there's anything else I can do :).