[RFC] refactor: only load filenames to decrease loading time #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lua/telescope-orgmode/org.lua
Outdated
Comment on lines
7
to
10
| local file_results = vim.tbl_map(function(filename) | ||
| local file_stat = vim.uv.fs_stat(filename) or 0 | ||
| return { filename = filename, last_used = file_stat.mtime.sec } | ||
| end, require('orgmode').files:_files()) |
There was a problem hiding this comment.
Try doing this:
Suggested change
| local file_results = vim.tbl_map(function(filename) | |
| local file_stat = vim.uv.fs_stat(filename) or 0 | |
| return { filename = filename, last_used = file_stat.mtime.sec } | |
| end, require('orgmode').files:_files()) | |
| local file_results = vim.tbl_map(function(file) | |
| return { filename = file.filename, last_used = file.metadata.mtime, title = file:get_title() } | |
| end, require('orgmode').files:all()) |
| filename = file_entry.filename, | ||
| -- not beautiful to access a private property, but this is the only way to get the title | ||
| ---@diagnostic disable-next-line: invisible, undefined-field | ||
| title = file_entry.file._file:get_directive('TITLE') or nil, |
There was a problem hiding this comment.
get the title from the file result after the suggested change below.
Maltimore
force-pushed
the
just_load_filenames
branch
from
eea012a to
458a7ec
Compare
|
Thanks a ton for your help. Worked flawlessly. I'm marking this ready for review! (This is AFAIK my first-ever commit to a lua project so be careful!) |
Maltimore
changed the title
kristijanhusak
approved these changes
Jul 1, 2025
There was a problem hiding this comment.
LGTM. I'll let @seflue confirm and merge this in, I'm not really a user of this plugin.
|
Changes look good, thanks to both of you. 👍 |
seflue
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in nvim-orgmode/orgmode#999, this is a first attempt to reduce the loading time of getting the org files.
The downside of this PR is that we are not parsing the TITLE anymore, so telescope entries are just based on the filename.