refactor(#2875): multi instance renderer #2900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
changed the base branch from
master
to
explore-reloaders-multiinstance
alex-courtis
changed the base branch from
explore-reloaders-multiinstance
to
master
alex-courtis
changed the base branch from
master
to
explore-reloaders-multiinstance
alex-courtis
changed the base branch from
explore-reloaders-multiinstance
to
master
alex-courtis
force-pushed
the
multiinstance-renderer
branch
from
b1b8d3b to
9735e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2875
Dogfooding for one week.
TODO, maybe better to follow up with another PRrenderer.components.icons classrenderer.components.icons remove switching proxycollapse builder into rendererconsider classes for remaining components