This repository was archived by the owner on Dec 22, 2020. It is now read-only.
Query order execution fix #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andreamaioli for this PR, but the native part of this plugin comes from cordova-sqlite-storage, and since I am not very comfortable with this part (I coded only the JavaScript wrapper), I'd prefer to stick to the original code. Do you know if your issue has already been fixed in cordova-sqlite-storage? If so, I could just update this plugin with the latest version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Manuel,
thanks for your sqlite plugin.
We have spotted a problem in the order of query execution, which is not guaranteed if the workload is high. This is because the runInBackground method uses a concurrent queue, not a serial one.
The proposed changes solve the problem by serializing the queries directly in the plugin.