Async callbacks & multi-isolate store access #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good solution! |
vaind
force-pushed
the
async-and-isolates
branch
2 times, most recently
from
76ed6ce to
713b4f4
Compare
This was referenced Nov 26, 2020
Closed
vaind
changed the title
Merged
vaind
force-pushed
the
async-and-isolates
branch
from
713b4f4 to
112d995
Compare
RTrackerDev
reviewed
Dec 3, 2020
vaind
force-pushed
the
async-and-isolates
branch
3 times, most recently
from
04c8be9 to
860c8ea
Compare
|
LGTM as far as I understand (no deep knowledge of streams and isolates; only had a glimpse at C API for Dart). |
vaind
force-pushed
the
async-and-isolates
branch
2 times, most recently
from
83bc0e4 to
ba44326
Compare
vaind
force-pushed
the
async-and-isolates
branch
from
ba44326 to
054a345
Compare
vaind
force-pushed
the
async-and-isolates
branch
from
4f3aa6a to
6bef12c
Compare
vaind
force-pushed
the
async-and-isolates
branch
from
6bef12c to
46b64b4
Compare
C-API v0.12.0 Java v2.9.0 Swift v1.5.0
vaind
force-pushed
the
async-and-isolates
branch
from
c3d6c89 to
b1f49a2
Compare
vaind
force-pushed
the
async-and-isolates
branch
from
b1f49a2 to
035441a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes necessary are pretty simple - just allow creating Store from an existing
OBX_StoreC pointer and pass that between isolates. Any ideas how to improve/simplify that for users? I don't really know the most common isolates' usage patterns in Dart/Flutter yet so I'm open to suggestions.However, to get it working, we had to do some custom stuff to send handle async callbacks (issue #142) - objectbox-c now (v0.12+) includes dart-specific functionality to connect to a dart runtime and send callback data over streams. This required a rework of the observers.
Besides the above, this PR also implements sync listeners.