Skip to content

Android setup simplification #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Android setup simplification #79

merged 1 commit into from
Dec 2, 2019

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Nov 29, 2019

Fixes #73

@greenrobot-team
Copy link
Member

Reviewing...

Copy link
Member

@greenrobot-team greenrobot-team left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To speak in Gradle terms: instead of the user manually adding the dependency, automatically depend on a project/module ("Flutter plugin") that brings in the dependency. Straightforward solution, I guess.

Anyhow: I failed to generate objectbox.g.dart for the example using flutter pub run build_runner build (succeeds, but no changes; Flutter (Channel beta, v1.11.0, on Microsoft Windows [Version 10.0.18363.476], locale de-DE)). But I suppose Ivan tested that the app still works (I see no reason looking at the dependency graph, why it shouldn't).

@liquidiert
Copy link
Contributor

@greenrobot-team dunno if it helps but I'm using object box 0.4.0 in one of my current projects and I can build my g parts 👌

@vaind vaind force-pushed the 73-android-improvement branch from 25a34f8 to 3662934 Compare December 2, 2019 12:39
@vaind vaind merged commit b6cb395 into dev Dec 2, 2019
@greenrobot-team
Copy link
Member

@liquidiert Thanks for that! Turns out it failed due to a regression introduced with an unrelated change in the development version.

@vaind vaind deleted the 73-android-improvement branch December 18, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants