Skip to content

design tweaks #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2024
Merged

design tweaks #1591

merged 2 commits into from
Aug 21, 2024

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Aug 20, 2024 •
edited
Loading

This…

  • Uses normal font-weight instead of 500 for body text (preference)
  • Adopts phosphate as the focus color instead of blue (to reduce the number of accent colors)
  • Adopts phosphate as the CTA color for “Get started” on the home page (ditto)
  • Adopts Inter as the sans-serif font instead of San Francisco (to reduce the number of fonts)
  • Adopts Spline Sans Mono as the monospace font for code instead of Menlo (ditto)
  • Tweaks the font-size for code and tt elements to inherit (due to the above changes)
before after
Screenshot 2024-08-20 at 8 58 37 PM Screenshot 2024-08-20 at 8 58 27 PM
Screenshot 2024-08-20 at 8 59 48 PM Screenshot 2024-08-20 at 8 59 38 PM
Screenshot 2024-08-20 at 9 00 41 PM Screenshot 2024-08-20 at 9 00 23 PM
Screenshot 2024-08-20 at 9 01 36 PM Screenshot 2024-08-20 at 9 01 29 PM

@mbostock mbostock requested a review from Fil August 20, 2024 22:48
@mbostock mbostock changed the title revert to normal font-weight design tweaks Aug 21, 2024
@mbostock mbostock enabled auto-merge (squash) August 21, 2024 02:03
@mbostock mbostock mentioned this pull request Aug 21, 2024
Merged
@mbostock mbostock merged commit 329d89c into main Aug 21, 2024
4 checks passed
Fil
Fil approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@mbostock mbostock deleted the mbostock/font-weight-normal branch August 21, 2024 06:27
@Fil Fil mentioned this pull request Aug 21, 2024
Merged
@kohlhofer
Copy link

Looks good to me!

@mbostock
Copy link
Member Author

Followup in #1594.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbostock @kohlhofer @Fil