Mark TODOs as comments and add Inputs.search documentation #518
Conversation
| @@ -23,13 +28,29 @@ Or, as a table: | |||
| ```js echo | |||
| Inputs.table(search) | |||
There was a problem hiding this comment.
TODO: write documentation on why:
Inputs.table(search)andview(Inputs.table(search))have the same behavior but- but
Inputs.table(search);(with the semicolon) doesn't display the table
There was a problem hiding this comment.
this is a generic issue, not linked to this particular input
| @@ -1,6 +1,8 @@ | |||
| # Search input | |||
|
|
|||
| [TODO] check on Hello, Inputs removed below. | |||
| [Examples ›](https://observablehq.com/@observablehq/input-search) [API Reference ›](https://github.com/observablehq/inputs/blob/main/README.md#search) | |||
There was a problem hiding this comment.
@allisonhorst should we add the API link right after the h2 header?
There was a problem hiding this comment.
Yes let's add it there for now.
| @@ -1,6 +1,8 @@ | |||
| # Search input | |||
|
|
|||
| [TODO] check on Hello, Inputs removed below. | |||
| [Examples ›](https://observablehq.com/@observablehq/input-search) [API Reference ›](https://github.com/observablehq/inputs/blob/main/README.md#search) | |||
There was a problem hiding this comment.
Yes let's add it there for now.
| [TODO] check on Hello, Inputs removed below. | ||
| [Examples ›](https://observablehq.com/@observablehq/input-search) [API Reference ›](https://github.com/observablehq/inputs/blob/main/README.md#search) | ||
|
|
||
| <!-- [TODO] check on Hello, Inputs removed below. --> |
There was a problem hiding this comment.
An update for all of these re: Hello, Inputs: I've tried including content from Hello, Inputs into the Inputs overview doc (#516 ) so that we don't point elsewhere (and especially not a notebook since viewof vs. view, etc.).
| @@ -11,7 +13,12 @@ const penguins = FileAttachment("penguins.csv").csv({typed: true}); | |||
| ``` | |||
|
|
|||
| ```js echo | |||
| const search = view(Inputs.search(penguins)); | |||
| const searchInput = Inputs.search(penguins); | |||
There was a problem hiding this comment.
(this is the one we chatted about) we can compare to example in lib/inputs#search and update for consistency.
No description provided.