Skip to content

explicitly check home dir for user config #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 18, 2024
Merged

explicitly check home dir for user config #558

merged 3 commits into from
Jan 18, 2024

Conversation

mythmon
Copy link
Member

@mythmon mythmon commented Jan 17, 2024 •
edited
Loading

Fixes #528

In this PR I also changed all the config loading to use an effects object, so I could write tests. That made the PR quite a bit bigger.

@mythmon mythmon requested review from mcglincy and trebor January 17, 2024 20:14
@mythmon mythmon enabled auto-merge (squash) January 18, 2024 17:44
trebor
trebor approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@trebor trebor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've tested this change with the current create and it works well.

the code looks good to me, but i've not been in this code before, so i may not have the most critical eye.

@mythmon mythmon merged commit 2bcb447 into main Jan 18, 2024
@mythmon mythmon deleted the mythmon/240117/config-outside-home branch January 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcglincy mcglincy Awaiting requested review from mcglincy

1 more reviewer

@trebor trebor trebor approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't deploy from outside home directory
2 participants
@mythmon @trebor