Skip to content

Conversation

GordonSmith
Copy link

Very opinionated I am afraid - just using what I am used to...

A bit opinionated, just using what I am used to...

Signed-off-by: Gordon Smith <[email protected]>
@Fil
Copy link
Contributor

Fil commented Mar 2, 2024

Is this still useful after #944?

@mbostock
Copy link
Member

mbostock commented Mar 2, 2024

We adopted cross-env for mocha at least.

@GordonSmith
Copy link
Author

@Fil - Has #944 been tested in both a git bash shell (on windows) and a cmd prompt? Am happy to close, was just sharing a quick fix I made to see it work OMM.

@GordonSmith GordonSmith closed this Mar 4, 2024
@Fil
Copy link
Contributor

Fil commented Mar 4, 2024

@GordonSmith if you can test on your side please report any findings—it will be very useful.

@GordonSmith
Copy link
Author

@Fil tested with cmd + PowerShell:

  1. npm run build
load docs/quakes.json.sh → [missing] 'sh' is not recognized as an internal or external command,
operable program or batch file.
error in 31ms: spawn sh ENOENT

Which would be expected...

  1. npm run dev:
    Hangs after tsx watch docs/theme/generate-themes.ts as & does not work as expected.

  2. npm run test:
    Fails on build:mocha due to cp not being recognised as a command.

@mbostock
Copy link
Member

mbostock commented Mar 4, 2024

If cp doesn’t exist then how are the tests passing on Windows? 🤔

https://github.com/observablehq/framework/actions/runs/8141979376/job/22250489360

@GordonSmith
Copy link
Author

GordonSmith commented Mar 4, 2024

cp exists in git bash (on windows) and PowerShell, but not the regular command shell...

@GordonSmith
Copy link
Author

GordonSmith commented Mar 4, 2024

call git bash command prompt PowerShell
npm run build pass fail (expected) fail (expected)
npm run dev pass fail (due to &) fail (due to &)
npm run test pass fail (due to cp) pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants