Skip to content

Update observable.tmpl #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2025
Merged

Conversation

CobusT
Copy link
Contributor

@CobusT CobusT commented Aug 21, 2025

The "suggest changes" links at the bottom of the docs pages are not working. It places an additional /notebook-kit into the url.

This removes notebook-kit from the base url since the location.pathname already has notebook-kit in it.

The "suggest changes" links at the bottom of the docs pages are not working. It places an additional `/notebook-kit` into the url. 

This removes `notebook-kit` from the base url since the `location.pathname` already has `notebook-kit` in it.
@CobusT CobusT requested a review from mbostock August 21, 2025 01:41
@mbostock
Copy link
Member

Ooh, good catch, thank you! I think I want to fix this on the JavaScript side so that the static link still points to the notebook-kit repo, though. I’ll edit this branch.

@mbostock mbostock enabled auto-merge (squash) August 21, 2025 03:02
@mbostock mbostock merged commit 864b738 into main Aug 21, 2025
1 check passed
@mbostock mbostock deleted the cobus/fix-suggest-changes-url-in-docs branch August 21, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants