Skip to content

What should scale.reverse do? #448

Closed
@Fil

Description

@Fil

After I fixed {reverse} in #415 I've tried to check all the uses of reverse in scales.

The documentation states that it reverses the domain.

As we've seen in #415 this didn't work for threshold and quantile scales (now fixed by reversing the range).

Other questions are:

  • make sure that "reversing the domain" never mutates the domain we pass?

  • (on color scales) why do we flip the interpolate if the scale has a truthy reverse option (we don't flip the range if we are on an ordinal scale). This results (I think?) in an erroneous mapping in the color legend (though not in the plot itself (??)); see seattle-temperature-band.

  • reverse: true on a radius scale r results weird because the sqrt is not flipped.

We need unit tests for all of this.

Metadata

Metadata

Assignees

Labels

questionFurther information is needed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions