-
Notifications
You must be signed in to change notification settings - Fork 184
Warn users when facet data doesn't match mark data #1014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Mike. I’m trying to guide you on how to express the logic—let me know if I can clarify anything by meeting/chatting directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the test/example also, because in this case it is not easily fixable: first, you would have to specify facet: true
on the three marks, and second you'd be disappointed by the result :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the extra facet_warning.svg snapshot, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Mike Bostock <[email protected]>
Co-authored-by: Mike Bostock <[email protected]>
* logic & wording * remove fcet_warning.svg * An arguably better test/example plot.
Not sure how to remove the warning from the yarn test log—but this doesn't seem to be blocking
A small issue with the wording is that it mentions |
True, but that is the documented default. We could change this warning to only trigger when the |
Closes #1009. Provides a warning when facet data doesn't strictly match mark data.
Note, I'm unsure if the logic or wording are exactly what we want.
Logic to trigger the warning:
Warning text: Facet data must strictly equal mark data for appropriate faceting. Make sure you aren't filtering your facet data in the Plot command