Skip to content

document vector #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2023
Merged

document vector #1377

merged 3 commits into from
Mar 24, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 23, 2023

For #1343

First mark to be documented with its default tuples, and X, Y variants. Once we agree on the wording, it will be used as a template for all similar marks.

I tried to make a simple sentence describing the mark with its (main) options in bold—not sure if this will work for all marks.

@Fil Fil requested a review from mbostock March 23, 2023 16:59
@mbostock mbostock enabled auto-merge (squash) March 24, 2023 00:47
@mbostock mbostock merged commit 1ad8b07 into main Mar 24, 2023
@mbostock mbostock deleted the fil/ts-vector branch March 24, 2023 00:49
Comment on lines +44 to +45
* Defaults to 0 degrees with the vector pointing up; positive angles proceed
* clockwise.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeats "clockwise"

chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* document vector

* VectorShape, not VectorShapeSpec

* edits

---------

Co-authored-by: Mike Bostock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants