-
Notifications
You must be signed in to change notification settings - Fork 184
document vector #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
document vector #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
mbostock
reviewed
Mar 23, 2023
mbostock
reviewed
Mar 23, 2023
mbostock
reviewed
Mar 23, 2023
mbostock
reviewed
Mar 23, 2023
mbostock
reviewed
Mar 23, 2023
mbostock
reviewed
Mar 23, 2023
mbostock
reviewed
Mar 23, 2023
mbostock
reviewed
Mar 23, 2023
mbostock
reviewed
Mar 23, 2023
mbostock
approved these changes
Mar 24, 2023
Fil
commented
Mar 24, 2023
Comment on lines
+44
to
+45
* Defaults to 0 degrees with the vector pointing up; positive angles proceed | ||
* clockwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repeats "clockwise"
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* document vector * VectorShape, not VectorShapeSpec * edits --------- Co-authored-by: Mike Bostock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1343
First mark to be documented with its default tuples, and X, Y variants. Once we agree on the wording, it will be used as a template for all similar marks.
I tried to make a simple sentence describing the mark with its (main) options in bold—not sure if this will work for all marks.