tip option #1537
Merged
tip option #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it! One thing to consider, is whether dodgeY should default to x—using xy in that case feels more natural to me, and also more usable on mobile. ymmv |
|
You’re right; I overindexed on the test case. I’ve removed the one-dimensional defaults for dodge. 🙏 |
57 tasks
Fil
approved these changes
May 11, 2023
mbostock
force-pushed
the
mbostock/tip-option
branch
from
c2e38ea to
794c70a
Compare
chaichontat
pushed a commit
to chaichontat/plot
that referenced
this pull request
Jan 14, 2024
* tip option * remove dodge tip default * sort import * withTip helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a tip option for generating a tip mark + pointer interaction from a given mark. It can be set to x, y, or xy for pointerX, pointerY, or pointer respectively, or to true in which case the default orientation is used (such as x in conjunction with implicit stackY). When plotting, these marks are created implemented and drawn atop all other marks.
In the future, perhaps the tip option could be specified as an object allowing additional tip options such as anchor.