Skip to content

inline facets and axes #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 10, 2022
Merged

inline facets and axes #799

merged 8 commits into from
Mar 10, 2022

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Mar 9, 2022 •
edited
Loading

A few internal improvements derived from the mbostock/layout branch:

  • Don’t wrap all marks in a Facet mark when faceting; handle faceting directly.
  • Don’t try to treat AxisX and AxisY as marks; render them directly.
  • Override mark.filter instead of passing defaults.filter to the constructor.
  • Rename a few local variables.

@mbostock mbostock requested a review from Fil March 9, 2022 19:14
@mbostock mbostock force-pushed the mbostock/cleaning branch from 3eb05e0 to 9428166 Compare March 9, 2022 19:27
@mbostock mbostock marked this pull request as draft March 9, 2022 20:35
@mbostock mbostock force-pushed the mbostock/cleaning branch 2 times, most recently from 4292468 to 1a67807 Compare March 9, 2022 20:54
@mbostock mbostock marked this pull request as ready for review March 9, 2022 20:54
@mbostock mbostock changed the title clean internals inline facets and axes Mar 9, 2022
@mbostock mbostock force-pushed the mbostock/cleaning branch from 1a67807 to 828fc56 Compare March 9, 2022 23:34
Fil
Fil approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful!

@mbostock mbostock merged commit 66142e2 into main Mar 10, 2022
@mbostock mbostock deleted the mbostock/cleaning branch March 10, 2022 17:15
@mbostock mbostock mentioned this pull request Mar 10, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbostock @Fil