Skip to content

Gabriel, Urquhart, and minimal spanning tree #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jun 14, 2022

three subgraphs of Delaunay, for #928

Currently implemented as named meshes. I don't think the API is the most elegant, and I'd rather change it to an option of the delaunayLinks and delaunayMesh marks (?). Anyway, it's fun and it seems useful, maybe?.

The associated code is also at https://observablehq.com/@fil/delaunay-sub-graphs

@Fil Fil requested a review from mbostock June 14, 2022 15:32
@Fil
Copy link
Contributor Author

Fil commented Jun 14, 2022

Capture d’écran 2022-06-14 à 17 33 03

Capture d’écran 2022-06-14 à 17 32 54

Capture d’écran 2022-06-14 à 17 32 47

@Fil Fil mentioned this pull request Jun 14, 2022
10 tasks
@Fil Fil force-pushed the fil/delaunay-subgraphs branch 2 times, most recently from 771c643 to 34fff9a Compare June 15, 2022 07:38
@mbostock
Copy link
Member

This feels niche to me; it’s cool but I’m not sure how I’d use it? I would be more supportive of this as a general pattern rather than these specific graphs. I.e., what would be a good way to do this without needing it to be built-in to Plot?

@Fil
Copy link
Contributor Author

Fil commented Jun 17, 2022

I don't know, I felt delaunay was niche already. But if we want to measure nicheness, I'd argue that the mst might be more useful (to highlight a group of points) than the delaunay mesh.

The convex hull is obviously the most common (and simplest to understand) subgraph.

The Gabriel and Urquhart subgraphs, if very nice to look at, are probably not generically useful. But in a cartographic metaphor, where the data's densest/clumpy areas are villages and towns, the urquhart graph looks like the roads that would connect them.

In terms of API, I'll have to think a bit more. Currently by construction it doesn't allow types of graphs that aren't subsets of the delaunay.

@mbostock
Copy link
Member

mbostock commented Jun 17, 2022

The only reason I added Delaunay was to support Voronoi and convex hull, which together have several known use cases. Hiding Delaunay when it’s needed to support those cases felt overly strict. But adding more subsets of the Delaunay triangulation seems more niche. Though I’d be more supportive, as I said, if it were a generic extensible mechanism rather than adding a handful of specific subgraphs.

@Fil Fil force-pushed the fil/delaunay-subgraphs branch from 34fff9a to 441f78a Compare July 22, 2022 10:33
@Fil
Copy link
Contributor Author

Fil commented Feb 6, 2023

cleaning this for now; might revisit some day in the future

@Fil Fil closed this Feb 6, 2023
@Fil Fil deleted the fil/delaunay-subgraphs branch February 6, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants