feat(cli): connect to cluster #813
Conversation
|
|
done |
|
All of the issues found in
By the way, I thick this is because, for the combined type, |
|
@chris-sun-star Could you please see this? |
| if err != nil { | ||
| if kubeerrors.IsNotFound(err) { | ||
| return fmt.Errorf("OBCluster %s not found", o.Name) | ||
| } else { |
There was a problem hiding this comment.
Please fix the lint problem showed in this page.
There was a problem hiding this comment.
There's only 2 problems, you don't need to handle the previously pushed code.
| return fmt.Errorf("password is not specified and not found in secrets") | ||
| } | ||
|
|
||
| if o.TenantName != DEFAULT_TENANT_NAME && o.User != DEFAULT_USER { |
There was a problem hiding this comment.
Is here something missing
| logger := utils.GetDefaultLoggerInstance() | ||
| cmd := &cobra.Command{ | ||
| Use: "connect <cluster_name>", | ||
| Short: "Connect to an ob cluster by sys tenant", |
There was a problem hiding this comment.
It's not only sys tenant
There was a problem hiding this comment.
So actually, we just need one single command for tenant module?
There was a problem hiding this comment.
I just mean the description, you've provided an option to pass the tenant name
|
Thanks again for your comment~ And I will fix the problem then. |
3 participants
Summary
Now we can use okctl to connect to cluster by sys tenant, the function for connecting to other tenant is in progress.
Solution Description