Eio-compatible representation for response Body #260
Merged
+236
−176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
force-pushed
the
ocsigen_response_eio
branch
from
d62968b to
44a4cf1
Compare
|
I marked this as draft as I still couldn't make this work. |
|
The bug is now fixed. This is ready to be reviewed ! |
Julow
commented
May 21, 2025
This changes the representation of the body of the response to be compatible with Cohttp-eio. This now uses 'Cohttp_lwt_unix.Server.make_expert', which expect a representation for the body that is closer to direct-style instead of using the same Body type as for requests. The setting of cookie headers is moved into 'Ocsigen_response', with the goal of building a safer API.
Rewrite 'Deflatemod' to operate on 'Ocsigen_response.Body' directly instead of on 'Ocsigen_stream'. 'Ocsigen_stream' will no longer be compatible with Cohttp-eio's response type.
This adds functions from `Cohttp_lwt_unix.Server` that are no longer available with cohttp-eio.
In cohttp-eio, the transfer encoding is no longer propagated through the `Body.t` type. Instead, it must be propagated separately.
Julow
force-pushed
the
ocsigen_response_eio
branch
from
04a2f29 to
a4d22c4
Compare
|
This is required for other work towards the transition to Eio so I'll merge now. I rebased on top of the new tests, which don't show regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires Eliom with this change: ocsigen/eliom#834
This changes the representation of the body of the response to be compatible with Cohttp-eio.
This now uses
Cohttp_lwt_unix.Server.make_expert, which expect a representation for the body that is closer to direct-style IO instead of using the same Body type as for requests.The setting of cookie headers is moved into
Ocsigen_response, with the goal of eventually building a safer API.