[BUG]: octokit is missing its @octokit/webhooks dependency

[orionmiz]

What happened?

webhooks property type of App cannot be resolved when using Yarn's Plug'n'Play mode.

Here's dist-types/app.d.ts in [email protected]:

import { App as DefaultApp } from "@octokit/app";
import { OAuthApp as DefaultOAuthApp } from "@octokit/oauth-app";
export declare const App: (new (...args: any[]) => {
    // ...
    webhooks: import("@octokit/webhooks").Webhooks<{ // this property resolves its type as `any`.
        octokit: import("@octokit/core").Octokit & {
            paginate: import("@octokit/plugin-paginate-rest").PaginateInterface;
        } & import("@octokit/plugin-paginate-graphql").paginateGraphQLInterface & import("@octokit/plugin-rest-endpoint-methods").Api & {
            retry: {
                retryRequest: (error: import("@octokit/request-error").RequestError, retries: number, retryAfter: number) => import("@octokit/request-error").RequestError;
            };
        };
    }>;
    // ...
}) & typeof DefaultApp;

It's a typical ghost dependency problem; Exported App type requires dependencies from @octokit/app to be specified in octokit's dependencies as well though it's just exporting the types, not actual module.

Here's a workaround for pnp users like me:

packageExtensions:
  octokit@*:
    dependencies:
      "@octokit/webhooks": "*"

Versions

octokit@npm:4.1.3

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[github-actions]

🎉 This issue has been resolved in version 5.0.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 4.1.4 🎉

The release is available on:

• GitHub release
• npm package (@release-4.x dist-tag)

Your semantic-release bot 📦🚀