[IMP] accounting: update analytic accounting with changes from 17.0 #13380
Conversation
|
|
There was a problem hiding this comment.
Hey @afma-odoo , good job overall, but I think the Analytic Distribution Models section needs a little more work. Let me know if any of my comments were unclear or if you need help brainstorming better explanations of the fields on analytic distribution models!
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Show resolved
Hide resolved
afma-odoo
force-pushed
the
17.0-accounting-analytic-accounting-afma
branch
from
6af052a to
0e4f2ef
Compare
|
@dade-odoo Thanks for the review and your suggestions/comments, especially for the analytic distribution model section! |
There was a problem hiding this comment.
Hi @afma-odoo , just a few more comments here. I'll go ahead and approve and you can ping for a final review whenever you've made the updates :) Of course, please reach out if you have any questions about my comments!
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
afma-odoo
force-pushed
the
17.0-accounting-analytic-accounting-afma
branch
from
0e4f2ef to
4565166
Compare
|
Hi @dade-odoo, Thanks for your comments! Let me know if there is any way I can improve the page further |
There was a problem hiding this comment.
Thank you for your work @afma-odoo and @dade-odoo ! I added a few minor comments and suggestions 🙂
Also, I'm clearly nitpicking here but I think you forgot the app's name in the anchor names 🙈
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
content/applications/finance/accounting/reporting/analytic_accounting.rst
Outdated
Show resolved
Hide resolved
afma-odoo
force-pushed
the
17.0-accounting-analytic-accounting-afma
branch
from
4565166 to
6e102e6
Compare
|
@auva-odoo Thank you for your review! And for the anchors 😳 |
auva-odoo
force-pushed
the
17.0-accounting-analytic-accounting-afma
branch
from
6e102e6 to
46e385d
Compare
There was a problem hiding this comment.
Thank you for the changes @afma-odoo. I force-pushed some minor changes (e.g., to remove commas, get rid of an unnecessary future tense, etc.). Thanks again!
@robodoo r+
task-4237582 closes #13380 Signed-off-by: Audrey Vandromme (auva) <[email protected]>
task-4237582