[REF] Outlook: rework logging attachments #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juwu-odoo
force-pushed
the
outlook-ref-attachments-juwu
branch
2 times, most recently
from
a76dfd1 to
079f87a
Compare
Currently logging emails with attachments can encounter several issues, including: - Error if there's a mismatch between the number of img tags and inline attachments - Images will sometimes be embedded in the wrong order - URL images are incorrectly overwritten This commit refactors logRequest to be invariant to the email body and possible missing, extra, and/or out-of-order attachments. This is done by processing the .eml data directly and mapping attachments directly to img tags via contentId. Processing the .eml data is needed since the outlook-js API does not expose a method to fetch the attachment's contentId.
juwu-odoo
force-pushed
the
outlook-ref-attachments-juwu
branch
from
079f87a to
0836d2a
Compare
std-odoo
reviewed
Jul 28, 2025
| @@ -37,6 +37,7 @@ | |||
| "fontawesome-4.7": "^4.7.0", | |||
| "node-forge": "^0.10.0", | |||
| "office-ui-fabric-react": "^7.139.0", | |||
| "postal-mime": "^1.1.0", | |||
There was a problem hiding this comment.
I'm really not a fan of adding dependencies :/
There was a problem hiding this comment.
I understand as well, and I'm not a fan either. Unfortunately, parsing the eml data is necessary since there the native office api does not expose the attachments' contentId. postal-mime was the smallest and most focused library I found to get this working end-to-end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently logging emails with attachments can encounter several issues, including:
This commit refactors logRequest to be invariant to the email body and possible missing, extra, and/or out-of-order attachments. This is done by processing the .eml data directly and mapping attachments directly to img tags via contentId. Processing the .eml data is needed since the outlook-js API does not expose a method to fetch the attachment's contentId.