[IMP] carousel: one title to rule them all #7003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasLefevre
force-pushed
the
master-single-carousel-title-lul
branch
4 times, most recently
from
47cbef0 to
a7b01c4
Compare
|
robodoo rebase-merge |
|
Merge method set to rebase and merge, using the PR as merge commit message. |
LucasLefevre
changed the title
This reverts commit d866f9d. See next commit message and task. Task: 5039276
This reverts commit 54dd3b8. See next commit message and task. Task: 5039276
LucasLefevre
force-pushed
the
master-single-carousel-title-lul
branch
from
a7b01c4 to
70e2d05
Compare
hokolomopo
reviewed
Sep 4, 2025
| ]); | ||
| }); | ||
|
|
||
| test("Can edit the carousel title for a carousel item", async () => { |
There was a problem hiding this comment.
nitpick: Can edit the carousel title for a carousel item
| <templates> | ||
| <t t-name="o-spreadsheet-CarouselPanel"> | ||
| <div class="o-carousel-panel h-100 overflow-auto"> | ||
| <Section title.translate="Carousel Title" class="'o-carousel-title'"> |
There was a problem hiding this comment.
Suggested change
| <Section title.translate="Carousel Title" class="'o-carousel-title'"> | |
| <Section title.translate="Carousel Title" class="'o-carousel-title pt-0'"> |
probably
There was a problem hiding this comment.
(in "Carousel Sections", not "Carousel Title" )
With this commit, we are simplifying the carousel. Previously, the user could define a different title for each carousel tab. Now, it's only a single title for all tabs. We are still not sure where we are going with carousels, but it seems the current direction is to use carousel to show the same data (hence one single title) but from different perspectives (tabs) Task: 5039276
hokolomopo
force-pushed
the
master-single-carousel-title-lul
branch
from
70e2d05 to
4bda34a
Compare
|
@robodoo r+ fixed the nitpicks |
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2025
This reverts commit d866f9d. See next commit message and task. Task: 5039276 Part-of: #7003 Signed-off-by: Adrien Minne (adrm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2025
This reverts commit 54dd3b8. See next commit message and task. Task: 5039276 Part-of: #7003 Signed-off-by: Adrien Minne (adrm) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 4, 2025
With this commit, we are simplifying the carousel. Previously, the user could define a different title for each carousel tab. Now, it's only a single title for all tabs. We are still not sure where we are going with carousels, but it seems the current direction is to use carousel to show the same data (hence one single title) but from different perspectives (tabs) Task: 5039276 Part-of: #7003 Signed-off-by: Adrien Minne (adrm) <[email protected]>
robodoo
added a commit
that referenced
this pull request
Sep 4, 2025
With this commit, we are simplifying the carousel. Previously, the user could define a different title for each carousel tab. Now, it's only a single title for all tabs. We are still not sure where we are going with carousels, but it seems the current direction is to use carousel to show the same data (hence one single title) but from different perspectives (tabs) closes #7003 Task: 5039276 Signed-off-by: Adrien Minne (adrm) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, we are simplifying the carousel.
Previously, the user could define a different title for each carousel tab.
Now, it's only a single title for all tabs.
We are still not sure where we are going with carousels, but it seems the
current direction is to use carousel to show the same data (hence one single
title) but from different perspectives (tabs)
Task: 5039276